✨(frontend) add multi columns support for editor #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/multi-colum-v2
branch
3 times, most recently
from
8be4380 to
d5483fd
Compare
lunika
reviewed
Jul 25, 2025
| dictionary: { | ||
| ...locales[lang as keyof typeof locales], | ||
| multi_column: | ||
| multiColumnLocales[lang as keyof typeof multiColumnLocales], |
There was a problem hiding this comment.
multiColumnLocales can be undefined so this code will crash the application
There was a problem hiding this comment.
If we switch to Vitest, I think we should be able to test correctly this part, for the moment it is complicated.
lunika
approved these changes
Jul 25, 2025
AntoLC
force-pushed
the
feature/multi-colum-v2
branch
from
7e29173 to
b67ab62
Compare
We add multi columns support for editor, now you can add columns to your document. Works with export. 📄AGPL feature.
AntoLC
force-pushed
the
feature/multi-colum-v2
branch
from
b67ab62 to
11d0baf
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We add multi columns support for editor, now you can add columns to your document.
Works with export.
Careful⚠️
📄AGPL feature.
Demo
Feature.multi.columns.-.Docs.online-video-cutter.com.mp4